Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Edit only Scan step in Modify action #693

Merged
merged 3 commits into from
Nov 8, 2024
Merged

feat: Edit only Scan step in Modify action #693

merged 3 commits into from
Nov 8, 2024

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Nov 8, 2024

This action is used in the three-dot menu of each file.

Also, updating the ScanResultDialog informations.
The information is no longer related to the device, but to the file type.

@Merkur39
feat: Edit only Scan step in Modify action
8676889 
This action is used in the three-dot menu of each file.
@Merkur39
feat: Remove unused file
d62d021
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 8, 2024 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ intents/mespapiers.(hash).js
 85.07KB (+177B +0.2%) -
✅ app/mespapiers.(hash).js
 1.64MB (+161B +0.01%) -
Unchanged files (39)
Status Path Size Limits
✅ vendors/mespapiers.(hash).js
 1.94MB -
✅ services/expiration/mespapiers.js
 1.75MB -
✅ services/metadataMigration/mespapiers.js
 398.96KB -
✅ services/launchTriggers/mespapiers.js
 396.55KB -
✅ img/IlluPassportDate.(hash).png
 38.4KB -
✅ img/IlluPassportNumber.(hash).png
 37.98KB -
✅ img/IlluPassport.(hash).png
 37.87KB -
✅ vendors-mespapiers.(hash).(hash).min.css
 36.56KB -
✅ img/IlluNationalHealthInsuranceCardNumber.(ha
sh).png
 24.89KB -
✅ img/IlluNationalHealthInsuranceCardDateHelp.(
hash).png
 24.64KB -
✅ img/IlluCafNumberHelp.(hash).png
 21.67KB -
✅ img/IlluIdCardNumberHelp.(hash).png
 13KB -
✅ img/IlluDriverLicenseBack.(hash).png
 12.72KB -
✅ img/IlluIdCardFront.(hash).png
 12.58KB -
✅ img/IlluIdCardBack.(hash).png
 12.43KB -
✅ img/IlluResidencePermitExpirationDateHelp.(ha
sh).png
 12.17KB -
✅ img/IlluResidencePermitNumberHelp.(hash).png
 12.16KB -
✅ img/IlluIdCardExpirationDateHelp.(hash).png
 12.09KB -
✅ img/IlluResidencePermitFront.(hash).png
 12.08KB -
✅ img/IlluDriverLicenseNumberHelp.(hash).png
 11.93KB -
✅ img/IlluDriverLicenseFront.(hash).png
 11.85KB -
✅ img/IlluDriverLicenseObtentionDateHelp.(hash)
.png
 11.74KB -
✅ img/IlluResidencePermitBack.(hash).png
 11.01KB -
✅ img/QRCode.(hash).png
 9.77KB -
✅ img/IlluNationalHealthInsuranceCardFront.(has
h).png
 9.39KB -
✅ img/IlluVehicleRegistration.(hash).png
 8.92KB -
✅ img/IlluNewNationalIdCardFront.(hash).png
 8.65KB -
✅ img/IlluOldNationalIdCardFront.(hash).png
 7.86KB -
✅ img/IlluDiploma.(hash).png
 5.59KB -
✅ img/IlluIBAN.(hash).png
 3.81KB -
✅ img/IlluCovidVaccineCertificate.(hash).png
 2.96KB -
✅ img/IlluInvoice.(hash).png
 2.33KB -
✅ img/IlluWorkContract.(hash).png
 2.24KB -
✅ img/marker-icon.(hash).png
 1.45KB -
✅ img/layers-2x.(hash).png
 1.25KB -
✅ img/layers.(hash).png
 719B -
✅ app-mespapiers.(hash).min.css
 569B -
✅ img/appstore.(hash).png
 362B -
✅ img/playstore.(hash).png
 328B -

Total files change +338B 0%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 6.68MB (+338B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ img/.
 401.43KB -
✅ **/*.css
 37.46KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

zatteo
zatteo approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@zatteo zatteo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean solutions 👍

@Merkur39
feat: Update ScanResultDialog informations
d1e42f8 
The information is no longer related to the device,
but to the file type.
@Merkur39 Merkur39 merged commit 0b9b2ba into master Nov 8, 2024
2 checks passed
@Merkur39 Merkur39 deleted the feat/ver-864 branch November 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Merkur39 @zatteo